Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

feat: optional HPA #64

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat: optional HPA #64

merged 2 commits into from
Dec 6, 2023

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Dec 6, 2023 •
edited
Loading

What does this PR do?

  1. Introduce optional HorizontalPodAutoscaler
  2. Move spec.replicas of Deployment to an optional field, as it is the case in K8s. It's far better to not set spec.replicas when using HPA.

Motivation

It can help on HA or production deployment.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

darkweaver87
darkweaver87 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit f19c1cb into traefik:main Dec 6, 2023
1 check passed
@mloiseleur mloiseleur deleted the feat/hpa branch December 6, 2023 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@youkoulayley youkoulayley youkoulayley approved these changes

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mloiseleur @darkweaver87 @youkoulayley @traefiker